Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(schemas): add saml_application_secres table #6816

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

darcyYe
Copy link
Contributor

@darcyYe darcyYe commented Nov 18, 2024

Summary

Add saml_application_secrets table.
A SAML app can correspond to ONE or MORE secrets, but ONLY ONE secret can be set as active.

Testing

Covered by CI.
The constraints mentioned here are implemented in the DB and will be added to integration tests after providing the API for operating secrets.

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Nov 18, 2024

COMPARE TO master

Total Size Diff 📈 +2.13 KB

Diff by File
Name Diff
packages/schemas/alterations/next-1731901231-add-saml-application-secrets-table.ts 📈 +1.35 KB
packages/schemas/tables/saml_application_secrets.sql 📈 +795 Bytes

@darcyYe darcyYe changed the title feat(schemas): add saml_application_secres table feat(schemas): add saml_application_secres table Nov 18, 2024
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch 2 times, most recently from d5c8533 to 8ede93b Compare November 18, 2024 11:01
@darcyYe darcyYe force-pushed the yemq-log-7205-add-saml-application-secrets-table branch 2 times, most recently from f3d1c51 to 47dd64b Compare November 19, 2024 07:57
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch from 8ede93b to 3a47e75 Compare November 20, 2024 06:32
@darcyYe darcyYe force-pushed the yemq-log-7205-add-saml-application-secrets-table branch from 47dd64b to 2d7fae3 Compare November 20, 2024 07:42
@darcyYe darcyYe force-pushed the yemq-log-10133-add-isVisible-to-applications-table branch 3 times, most recently from d947275 to e47545a Compare November 21, 2024 06:59
@darcyYe darcyYe force-pushed the yemq-log-7205-add-saml-application-secrets-table branch from 2d7fae3 to 7d8cc8d Compare November 21, 2024 07:13
Copy link
Contributor

@simeng-li simeng-li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from yemq-log-10133-add-isVisible-to-applications-table to master November 21, 2024 10:30
@darcyYe darcyYe force-pushed the yemq-log-7205-add-saml-application-secrets-table branch from 7d8cc8d to 4de3026 Compare November 21, 2024 11:10
@darcyYe darcyYe merged commit 2ad808c into master Nov 21, 2024
37 checks passed
@darcyYe darcyYe deleted the yemq-log-7205-add-saml-application-secrets-table branch November 21, 2024 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants