-
-
Notifications
You must be signed in to change notification settings - Fork 454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(schemas): add saml_application_secres
table
#6816
Merged
darcyYe
merged 3 commits into
master
from
yemq-log-7205-add-saml-application-secrets-table
Nov 21, 2024
Merged
feat(schemas): add saml_application_secres
table
#6816
darcyYe
merged 3 commits into
master
from
yemq-log-7205-add-saml-application-secrets-table
Nov 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyYe
requested review from
simeng-li,
wangsijie and
gao-sun
as code owners
November 18, 2024 03:51
COMPARE TO
|
Name | Diff |
---|---|
packages/schemas/alterations/next-1731901231-add-saml-application-secrets-table.ts | 📈 +1.35 KB |
packages/schemas/tables/saml_application_secrets.sql | 📈 +795 Bytes |
darcyYe
changed the title
feat(schemas): add saml_application_secres table
feat(schemas): add Nov 18, 2024
saml_application_secres
table
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
2 times, most recently
from
November 18, 2024 11:01
d5c8533
to
8ede93b
Compare
simeng-li
reviewed
Nov 19, 2024
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
2 times, most recently
from
November 19, 2024 07:57
f3d1c51
to
47dd64b
Compare
simeng-li
reviewed
Nov 20, 2024
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
from
November 20, 2024 06:32
8ede93b
to
3a47e75
Compare
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
November 20, 2024 07:42
47dd64b
to
2d7fae3
Compare
darcyYe
force-pushed
the
yemq-log-10133-add-isVisible-to-applications-table
branch
3 times, most recently
from
November 21, 2024 06:59
d947275
to
e47545a
Compare
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
November 21, 2024 07:13
2d7fae3
to
7d8cc8d
Compare
simeng-li
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Base automatically changed from
yemq-log-10133-add-isVisible-to-applications-table
to
master
November 21, 2024 10:30
darcyYe
force-pushed
the
yemq-log-7205-add-saml-application-secrets-table
branch
from
November 21, 2024 11:10
7d8cc8d
to
4de3026
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
saml_application_secrets
table.A SAML app can correspond to ONE or MORE secrets, but ONLY ONE secret can be set as
active
.Testing
Covered by CI.
The constraints mentioned here are implemented in the DB and will be added to integration tests after providing the API for operating secrets.
Checklist
.changeset