Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Update helm command to align with new charts generation #202

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Jan 21, 2025

Description

This PR is for updating the helm command generated by Logz.io Agent to align it to the new charts generation.

Caution

Important note: This PR should be merged only after releasing the new chart generation.

  • Update UI generated helm command (helm.json)
  • Update the command generated 'backstage' by the localhost agent

On another note, as part of a different PR, I think that we should address the duplicate code to improve maintainability and make working with this project more efficient and less clumsy.

The new full command is planned to be:
helm install -n monitoring --create-namespace \

  --set global.logzioRegion='us' \
  --set global.env_id='ENTER VALUE' \

  --set global.logzioLogsToken='LOGS_TOKEN' \  // logs OR trivy OR k8s objects OR deployEvents are enabled

  --set logs.enabled=true \
  --set logzio-logs-collector.enabled=true \
  --set logzio-fluentd.enabled=false \

  --set logzio-k8s-telemetry.metrics.enabled=true \

  --set global.logzioMetricsToken="METRICS_TOKEN" \  // metrics enabled

  --set logzio-k8s-telemetry.k8sObjectsConfig.enabled=true \

  --set logzio-apm-collector.enabled=true \
  --set global.logzioTracesToken='TRACE_TOKEN' \
  --set logzio-apm-collector.spm.enabled=true \
  --set logzio-apm-collector.serviceGraph.enabled=true \

  --set global.logzioSpmToken='SPM_TOKEN' \  // spm OR service graph enabled

  --set securityReport.enabled=true \

  --set deployEvents.enabled=true \
logzio-monitoring logzio-helm/logzio-monitoring

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

@8naama 8naama changed the title Release/monitoring v7 [Release] Update helm command to align with new charts generation Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant