Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1Password API #17

Merged
merged 6 commits into from
Aug 18, 2024
Merged

Add 1Password API #17

merged 6 commits into from
Aug 18, 2024

Conversation

8naama
Copy link
Contributor

@8naama 8naama commented Aug 18, 2024 •
edited
Loading

Add 1 Password API, to support it we needed:

  • to add next_body support
  • to take the next date filter from the last item in the response instead of the first item (I made the change only for 1Password request, because Cloudflare and Azure for example do need the first item for the most recent datetime filter)
  • support boolean in the value parameter at pagination stop indication 'equals' condition

Also added tests and updated the readme

@8naama 8naama requested review from yotamloe and ralongit August 18, 2024 09:40
ralongit
ralongit approved these changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@ralongit ralongit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, added small note

@8naama 8naama force-pushed the feature/1password branch from 0a7a8b7 to 49a82de Compare August 18, 2024 10:03
yotamloe
yotamloe requested changes Aug 18, 2024
View reviewed changes
Copy link
Contributor

@yotamloe yotamloe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job!! please see my comments

@8naama 8naama requested a review from yotamloe August 18, 2024 12:32
@8naama 8naama merged commit 673e3f2 into main Aug 18, 2024
4 checks passed
@8naama 8naama deleted the feature/1password branch September 22, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ralongit ralongit ralongit approved these changes

@yotamloe yotamloe yotamloe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@8naama @ralongit @yotamloe