Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] E2E tests stracture #24

Merged
merged 32 commits into from
Jan 20, 2025
Merged

[Refactor] E2E tests stracture #24

merged 32 commits into from
Jan 20, 2025

Conversation

yotamloe
Copy link
Contributor

@yotamloe yotamloe commented Jan 14, 2025

Description

  • Handle logger configuration in memory instead of disk
  • Introduced ApiE2ETest base class to provide common setup and teardown functionalities, and utility methods for running the main program and searching logs in Logz.io. (e2e_tests/api_e2e_test.py)
  • Added E2E tests for Azure and DockerHub modules, inheriting from the ApiE2ETest base class to leverage common functionalities. (e2e_tests/apis/test_e2e_azure.py, e2e_tests/apis/test_e2e_dockerhub.py)
  • Created a README file to guide developers on adding new E2E tests, setting environment variables, and using utility functions. (e2e_tests/README.md)
  • Added a new GitHub Actions workflow to run end-to-end tests on push events.
  • Removed old integration test files and refactored them to use the new E2E testing framework.

What type of PR is this?

(check all applicable)

  • 🍕 Feature
  • 🐛 Bug Fix
  • 🧑‍💻 Code Refactor
  • 🔥 Performance Improvements
  • ✅ Test
  • 🤖 Build / CI
  • ⏩ Revert

Added tests?

  • 👍 yes
  • 🙅 no, because they aren't needed
  • 🙋 no, because I need help from somebody

Copy link
Contributor

@8naama 8naama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!! left just a small comment 🎉

src/main.py Show resolved Hide resolved
@yotamloe yotamloe merged commit 1484853 into main Jan 20, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants