Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AIM-402 Add BullMQ metrics plugin #173

Merged
merged 23 commits into from
Jul 22, 2024
Merged

AIM-402 Add BullMQ metrics plugin #173

merged 23 commits into from
Jul 22, 2024

Conversation

drdaemos
Copy link
Collaborator

@drdaemos drdaemos commented Jul 17, 2024 •
edited
Loading

Changes

This PR adds a Fastify plugin that auto-discovers BullMQ queues, regularly collects metrics for them and exposes them via fastify-metrics global Prometheus registry (which is exposed on /metrics by metricsPlugin).

This PR also removes the Node v18.x from the matrix because it doesn't support loading env vars (which is required for tests) and because no other repo seem to rely on that version anymore.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@drdaemos drdaemos added the minor label Jul 17, 2024
@drdaemos drdaemos marked this pull request as ready for review July 17, 2024 12:28
@drdaemos drdaemos requested review from CarlosGamero and a team as code owners July 17, 2024 12:28
@drdaemos drdaemos requested a review from kibertoad July 17, 2024 12:29
@kibertoad
Copy link
Collaborator

btw, I'll add redis infra to this repotoday in a separate PR

@drdaemos
Copy link
Collaborator Author

btw, I'll add redis infra to this repotoday in a separate PR

oh that's awesome

kibertoad
kibertoad reviewed Jul 18, 2024
View reviewed changes
vitest.config.mts Outdated Show resolved Hide resolved
kibertoad
kibertoad reviewed Jul 19, 2024
View reviewed changes
vitest.config.mts Outdated Show resolved Hide resolved
@drdaemos drdaemos marked this pull request as draft July 19, 2024 08:38
CatchMe2
CatchMe2 reviewed Jul 19, 2024
View reviewed changes
README.md Outdated Show resolved Hide resolved
@drdaemos drdaemos marked this pull request as ready for review July 19, 2024 15:13
@drdaemos drdaemos self-assigned this Jul 22, 2024
@drdaemos drdaemos merged commit fdc6647 into main Jul 22, 2024
4 checks passed
@drdaemos drdaemos deleted the feat/bull-mq-plugin branch July 22, 2024 08:57
@drdaemos drdaemos mentioned this pull request Jul 22, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kibertoad kibertoad kibertoad approved these changes

@CarlosGamero CarlosGamero Awaiting requested review from CarlosGamero CarlosGamero is a code owner

@CatchMe2 CatchMe2 Awaiting requested review from CatchMe2

Assignees

@drdaemos drdaemos

Labels
minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@drdaemos @kibertoad @CatchMe2