Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AP-4397 support for multiple redis clients in BullMQ metrics #186

Merged
merged 5 commits into from
Aug 23, 2024
Merged

AP-4397 support for multiple redis clients in BullMQ metrics #186

merged 5 commits into from
Aug 23, 2024

Conversation

kjamrog
Copy link
Contributor

@kjamrog kjamrog commented Aug 20, 2024 •
edited
Loading

Changes

To use bullmq metrics plugin in Flow, we need to support multiple redis instances in configuration. Since redisClients are accepted as array now, it's a breaking change

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@kjamrog kjamrog added the minor label Aug 20, 2024
@kjamrog kjamrog added major and removed minor labels Aug 21, 2024
@kjamrog kjamrog requested a review from drdaemos August 21, 2024 10:31
@kjamrog kjamrog merged commit 1a746cb into main Aug 23, 2024
4 checks passed
@kjamrog kjamrog deleted the AP-4397_multiple_redis_clients_in_bullmq_metrics branch August 23, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CarlosGamero CarlosGamero CarlosGamero approved these changes

@kibertoad kibertoad kibertoad approved these changes

@drdaemos drdaemos drdaemos approved these changes

Assignees
No one assigned
Labels
major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kjamrog @drdaemos @kibertoad @CarlosGamero