chore: improve trailing slash plugin reliability #238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CatchMe2
requested review from
kibertoad,
CarlosGamero,
drdaemos and
a team
as code owners
kibertoad
reviewed
Feb 21, 2025
| ) | ||
| // Using a hardcoded origin for simplicity and reliability, | ||
| // as the request's origin is not relevant in this case. | ||
| const { pathname, search } = new URL(request.url, 'https://example.com') |
There was a problem hiding this comment.
can you also add a new test to ensure whatever case you are beefing up against is covered?
There was a problem hiding this comment.
We're not able to invoke local fastify app without specifying a port. I've changed the implementation, so the passed port doesn't matter.
kibertoad
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR improves logic in stripTrailingSlashPlugin by hardcoding origin. The previous implementation didn't work in case of missing port.
Checklist
major,minor,patchorskip-release