feat: add keyPrefix support for react-i18next #1176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds
keyPrefixsupport to react-i81next insideuseTranslationhook.This pull request was inspired by #770, but with code and functionality improvements.
As said in this comment (#770 (comment)), there was a problem that the
keyPrefixwent before the namespace and that the firstkeyPrefixin the file overwrote the laterkeyPrefix. Both were fixed.IntelliSense
The completion is showing according to the
keyPrefix. I also made an improvement to only show items from the current or default namespace, because in my opinion, it doesn't make sense to show items that are not within the current namespace.closes #719
closes #770