Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add base Biome config #203

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Add base Biome config #203

merged 2 commits into from
Jul 4, 2024

Conversation

kibertoad
Copy link
Collaborator

Changes

This provides a strawman proposal to kickstart the definition of our biome rules, any suggestions to adjust the rules would be most welcome.

Checklist

  • Apply one of following labels; major, minor, patch or skip-release
  • I've updated the documentation, or no changes were necessary
  • I've updated the tests, or no changes were necessary

@kibertoad kibertoad added the minor label Jul 3, 2024
@kibertoad kibertoad requested a review from dmitrybezly July 3, 2024 08:58
"arrowParentheses": "always",
"bracketSpacing": true,
"indentWidth": 2,
"indentStyle": "space",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 This will be hell to migrate. We're using tab in all of our FE projects. Should we stick to default tab configuration?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer to keep space-based indentation for packages and BE, though. can we do tab indentation as a FE-specific override?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure we can. Is BE using spaces by default (at Lokalise)?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, with the exception of Autopilot

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also create an override for AP(backend)? or do we want to migrate to space?

Copy link
Collaborator Author

@kibertoad kibertoad Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last time I ran a poll on this topic, 100% of AP engineers who participated selected the "I don't care" option, so it doesn't look like we need to maintain two separate sets of rules, we can just reformat it once and apply it within open PRs as well

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds great to me! 🙏 thanks for sharing Igor 🙇

@kibertoad kibertoad marked this pull request as ready for review July 4, 2024 12:15
@kibertoad kibertoad requested review from CarlosGamero, dariacm and a team as code owners July 4, 2024 12:15
@kibertoad kibertoad merged commit 10976f5 into main Jul 4, 2024
5 checks passed
@kibertoad kibertoad deleted the feat/biome-configs branch July 4, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants