-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add base Biome config #203
Conversation
"arrowParentheses": "always", | ||
"bracketSpacing": true, | ||
"indentWidth": 2, | ||
"indentStyle": "space", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 This will be hell to migrate. We're using tab in all of our FE projects. Should we stick to default tab configuration?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to keep space-based indentation for packages and BE, though. can we do tab indentation as a FE-specific override?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure we can. Is BE using spaces by default (at Lokalise)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yup, with the exception of Autopilot
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also create an override for AP(backend)? or do we want to migrate to space?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last time I ran a poll on this topic, 100% of AP engineers who participated selected the "I don't care" option, so it doesn't look like we need to maintain two separate sets of rules, we can just reformat it once and apply it within open PRs as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great to me! 🙏 thanks for sharing Igor 🙇
Changes
This provides a strawman proposal to kickstart the definition of our biome rules, any suggestions to adjust the rules would be most welcome.
Checklist
major
,minor
,patch
orskip-release