Adding biome.package.json #233
Conversation
| @@ -0,0 +1,11 @@ | |||
| { | |||
| "$schema": "../../../node_modules/@biomejs/biome/configuration_schema.json", | |||
| "extends": ["./biome-base.jsonc"], | |||
There was a problem hiding this comment.
unfortunately, extending from the same package is not supported by biome, it needs to be combined on a consumer side
There was a problem hiding this comment.
I was experiencing it right now 😓 then I guess that I should remove this remove on on package do
extends: [base, package]
right?
| @@ -0,0 +1,11 @@ | |||
| { | |||
There was a problem hiding this comment.
can you mention new preset in the documentation?
There was a problem hiding this comment.
On it, thank you!
There was a problem hiding this comment.
btw, is the following correct:
```json
{
"$schema": "./node_modules/@biomejs/biome/configuration_schema.json",
"extends": ["./node_modules/@lokalise/biome-config/configs/biome-base.jsonc", "./node_modules/@lokalise/biome-config/configs/biome-esm.jsonc"]
}
I think we are not using esm config, right? asking just to understand it 🙏
There was a problem hiding this comment.
newer services (Billing, Workflows) use ESM, Autopilot doesn't (benefits of a switch do not currently justify the effort needed)
There was a problem hiding this comment.
I see, thanks for explaining 🙏
|
Background-jobs-common had lint issues, they are not important and I don't think we need to release a new version of it so marking PR as |
CarlosGamero
requested review from
dariacm,
ondrejsevcik and
a team
as code owners
Changes
Please describe
Checklist
major,minor,patchorskip-release