Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove rooms from "websockets-common" package #53

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Drodevbar
Copy link
Contributor

This PR was created as a follow-up of Igor's comment regarding moving rooms away from shared-ts-lib package. This makes sense since the room names and their corresponding schemas are strictly AP thing.

Please see a corresponding PR that introduces websockets-rooms package into AP: https://github.com/lokalise/autopilot/pull/2392

@Drodevbar
Copy link
Contributor Author

@kibertoad I am not quite sure what's the best way to approach the issue I run into after extracting rooms to AP package.

The issue is:
packages/app/websockets-common/src/events/client-to-server/reservedRoomEvents.ts references a schema (ROOM_ID_SCHEMA) from rooms package. This schema references a function and this function references some types specific to the rooms.

This makes it impossible to fully get rid of rooms since some of the types created on top of them are still being referenced.

Do you think I should extract the whole websockets-common package out of this repo to AP? Or do you have some different idea in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant