Task bootstrap layout #26
Conversation
yuki1299
commented
Jan 9, 2020
yuki1299
commented
- Added Bootstrap Js files and created new js 'publisher_bootstrap' file
- Added Css Bootstrap files and created new css 'publisher_bootstrap' css file
- Created new controller and layout for publisher_bootstrap
- Changed Dummy Rails Project controller to render Publisher Bootstrap layout
- Updated nokogiri gem
- Added new loldesign logo white
- Added template js plugin files
- Added css files of sb-admin-2 bootstrap template
- Added custom styles folder of sb-admin-2 bootstrap template
- Created new helper LoldesignPublisherBootstrapHelper
- Updated Sidebar of loldesign_publisher (STATIC)
- Changed layout of dummy user index page with sb-admin-2 bootstrap temmplate
- Added more styles to new layout with bootstrap
- Created pages login and register
- Pagination Styles
- Responsive with new template bootstrap layout
- Added and configurated will_paginate gem
- Added metadata lines to enable responsive styles
- Added responsive search bar on topbar partial
- Updated loldesign_publisher version
- Created Errors page
- Updated loldesign_publisher version
- Added new default image -> 'logo_error'
- Fixed some layout details and new layout of 'new' pages
- Load Vex styles on bootstrap theme
- New layout of Show Screens
- Responsive styles of show screen with new bootstrap layout
- Added new author to gem
|
Hello, @yuki1299! This is your first Pull Request that will be reviewed by SourceLevel, an automatic Code Review service. It will leave comments on this diff with potential issues and style violations found in the code as you push new commits. You can also see all the issues found on this Pull Request on its review page. Please check our documentation for more information. |
![sourcelevel-bot[bot]](https://avatars.githubusercontent.com/in/597?s=60&v=4){kind=small}
| *= require_tree ./modules | ||
| *= require loldesign_publisher/override_publisher | ||
| *= require_tree ./plugins/vex | ||
| */ |
There was a problem hiding this comment.
Files must end with a new line
| $fs-unit: if(type-of($fs) == "number", unit($fs), false); | ||
|
|
||
| // Add !important suffix if needed | ||
| $rfs-suffix: if($important, " !important", ""); |
There was a problem hiding this comment.
Strings must use single quotes
| // Responsive font-size mixin | ||
| @mixin rfs($fs, $important: false) { | ||
| // Cache $fs unit | ||
| $fs-unit: if(type-of($fs) == "number", unit($fs), false); |
There was a problem hiding this comment.
Strings must use single quotes
| @if $rfs-breakpoint-unit-cache == "px" { | ||
| $rfs-breakpoint: $rfs-breakpoint / ($rfs-breakpoint * 0 + 1); | ||
| } | ||
| @else if $rfs-breakpoint-unit-cache == "rem" or $rfs-breakpoint-unit-cache == "em" { |
There was a problem hiding this comment.
Strings must use single quotes
| @if $rfs-breakpoint-unit-cache == "px" { | ||
| $rfs-breakpoint: $rfs-breakpoint / ($rfs-breakpoint * 0 + 1); | ||
| } | ||
| @else if $rfs-breakpoint-unit-cache == "rem" or $rfs-breakpoint-unit-cache == "em" { |
There was a problem hiding this comment.
Strings must use single quotes
| @if $rfs-breakpoint-unit-cache == "px" { | ||
| $rfs-breakpoint: $rfs-breakpoint / ($rfs-breakpoint * 0 + 1); | ||
| } | ||
| @else if $rfs-breakpoint-unit-cache == "rem" or $rfs-breakpoint-unit-cache == "em" { |
There was a problem hiding this comment.
Statement must start on the same line as the closing brace of the previous statement
| $rfs-breakpoint-unit-cache: unit($rfs-breakpoint); | ||
|
|
||
| // Remove unit from $rfs-breakpoint for calculations | ||
| @if $rfs-breakpoint-unit-cache == "px" { |
There was a problem hiding this comment.
Strings must use single quotes
| @if $rfs-base-font-size-unit == "px" { | ||
| $rfs-base-font-size: $rfs-base-font-size / ($rfs-base-font-size * 0 + 1); | ||
| } | ||
| @else if $rfs-base-font-size-unit == "rem" { |
There was a problem hiding this comment.
Strings must use single quotes
|
SourceLevel has finished reviewing this Pull Request and has found:
|
| $rfs-base-font-size-unit: unit($rfs-base-font-size); | ||
|
|
||
| // Remove px-unit from $rfs-base-font-size for calculations | ||
| @if $rfs-base-font-size-unit == "px" { |
There was a problem hiding this comment.
Strings must use single quotes
| $rfs-factor: 10 !default; | ||
|
|
||
| @if type-of($rfs-factor) != "number" or $rfs-factor <= 1 { | ||
| @error "`#{$rfs-factor}` is not a valid $rfs-factor, it must be greater than 1."; |
There was a problem hiding this comment.
Strings must use single quotes
| // Factor of decrease | ||
| $rfs-factor: 10 !default; | ||
|
|
||
| @if type-of($rfs-factor) != "number" or $rfs-factor <= 1 { |
There was a problem hiding this comment.
Strings must use single quotes
| } | ||
|
|
||
| .invisible { | ||
| visibility: hidden !important; |
| // | ||
|
|
||
| .visible { | ||
| visibility: visible !important; |
|
|
||
| // Reset | ||
|
|
||
| .text-reset { color: inherit !important; } |
|
|
||
| .text-break { | ||
| word-break: break-word !important; // IE & < Edge 18 | ||
| overflow-wrap: break-word !important; |
|
|
||
| .text-break { | ||
| word-break: break-word !important; // IE & < Edge 18 | ||
| overflow-wrap: break-word !important; |
There was a problem hiding this comment.
Expected word-break, found overflow-wrap
| .text-decoration-none { text-decoration: none !important; } | ||
|
|
||
| .text-break { | ||
| word-break: break-word !important; // IE & < Edge 18 |
| .text-decoration-none { text-decoration: none !important; } | ||
|
|
||
| .text-break { | ||
| word-break: break-word !important; // IE & < Edge 18 |
There was a problem hiding this comment.
Expected overflow-wrap, found word-break
| @include text-hide($ignore-warning: true); | ||
| } | ||
|
|
||
| .text-decoration-none { text-decoration: none !important; } |
| .text-muted { color: $text-muted !important; } | ||
|
|
||
| .text-black-50 { color: rgba($black, .5) !important; } | ||
| .text-white-50 { color: rgba($white, .5) !important; } |
| .text-muted { color: $text-muted !important; } | ||
|
|
||
| .text-black-50 { color: rgba($black, .5) !important; } | ||
| .text-white-50 { color: rgba($white, .5) !important; } |
There was a problem hiding this comment.
Color functions such as 'rgba' should only be used in variable declarations
| .text-body { color: $body-color !important; } | ||
| .text-muted { color: $text-muted !important; } | ||
|
|
||
| .text-black-50 { color: rgba($black, .5) !important; } |
| .text-body { color: $body-color !important; } | ||
| .text-muted { color: $text-muted !important; } | ||
|
|
||
| .text-black-50 { color: rgba($black, .5) !important; } |
There was a problem hiding this comment.
Color functions such as 'rgba' should only be used in variable declarations
| } | ||
|
|
||
| .text-body { color: $body-color !important; } | ||
| .text-muted { color: $text-muted !important; } |
| @include text-emphasis-variant(".text-#{$color}", $value); | ||
| } | ||
|
|
||
| .text-body { color: $body-color !important; } |
| .text-white { color: $white !important; } | ||
|
|
||
| @each $color, $value in $theme-colors { | ||
| @include text-emphasis-variant(".text-#{$color}", $value); |
There was a problem hiding this comment.
Strings must use single quotes
|
|
||
| // Contextual colors | ||
|
|
||
| .text-white { color: $white !important; } |
| .font-weight-normal { font-weight: $font-weight-normal !important; } | ||
| .font-weight-bold { font-weight: $font-weight-bold !important; } | ||
| .font-weight-bolder { font-weight: $font-weight-bolder !important; } | ||
| .font-italic { font-style: italic !important; } |
