Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/add-callback-and-async-callback #157

Conversation

sebastianbuechler
Copy link
Collaborator

This PR tackles #153 and #156 as they are related.

Addtionally to the reply method of the RequestHandler, I added a replyCallback and replyCallbackAsync that will take only the defined callback structures.

The replyCallback was straight forward to implement, where the replyCallbackAsync needed so more adjustments for the async handling throug out the codebase.

@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03% 🎉

Comparison is base (26eb57d) 99.25% compared to head (9a00440) 99.28%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #157      +/-   ##
==========================================
+ Coverage   99.25%   99.28%   +0.03%     
==========================================
  Files          24       24              
  Lines         267      280      +13     
==========================================
+ Hits          265      278      +13     
  Misses          2        2              
Files Changed Coverage Δ
lib/src/adapters/dio_adapter.dart 100.00% <100.00%> (ø)
lib/src/handlers/request_handler.dart 100.00% <100.00%> (ø)
lib/src/interceptors/dio_interceptor.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LukaGiorgadze LukaGiorgadze added bug Something isn't working enhancement New feature or request labels Aug 23, 2023
@LukaGiorgadze LukaGiorgadze merged commit a03d15b into lomsa-com:main Aug 23, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants