Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the project working with Wagtail 4.1+ #489

Open
wants to merge 49 commits into
base: master
Choose a base branch
from

Conversation

nickmoreton
Copy link
Collaborator

@nickmoreton nickmoreton commented Aug 30, 2024

Modernise the project for later versions of python, Django and Wagtail.

The aim is to support modern versions of Django and Wagtail and continue to use the existing tests to ensure compatibility.

  • Django >= 4.1, <= 4.2
  • Wagtail >= 4.1, <= 5.2
  • Python >= 3.9, <= 3.11

TODO: These are parts of the project that need further work.

  • Currently it may not be possible to use the longclaw.contrib apps
  • The dashboard panels need further work to be compatible with Wagtail 4.1+

and use FieldPanel instead of SnippetChooserPanel
@JamesRamm
Copy link
Collaborator

Happy to merge this when you are ready

@nickmoreton nickmoreton marked this pull request as ready for review September 1, 2024 06:39
@nickmoreton
Copy link
Collaborator Author

Hi @JamesRamm I think this is in a good pace to be merged now.

There's still a need to look at the contrib apps.

I think my next step will be to work on the use of modeladmin and use the replacement https://github.com/wagtail-nest/wagtail-modeladmin which will allow the app to be used up to the latest Wagtail 6.2 release

I also plan on updating the demo app: https://github.com/longclawshop/longclaw_demo that will help me understand what still needs fixing/updating. The start command creates a new site and that seems to be working OK but could do with some polish.

@nickmoreton
Copy link
Collaborator Author

I discovered while working on the demo app that the basket api url needed a small change. The node dependencies could do with an update so for now I have locked them to the original versions and bumped node to v16 to prevent errors when running npm install

@nickmoreton
Copy link
Collaborator Author

Hi @JamesRamm If you are happy with this so far I would like you to merge it now so that I can move forward with another round of updates over the next few weeks. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants