Allow to set annotations for the UI service #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Riccardo Petraglia <[email protected]> Signed-off-by: Riccardo Petraglia <[email protected]>
Signed-off-by: Riccardo Petraglia <[email protected]>
|
Indeed this is needed for me to use longhorn with external-dns 👍 |
|
Bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Thank you very much for your amazing work. I really like longhorn and this chart makes everything way easier!
This small contribution would allow to specify annotations for the UI service.
I am using this annotation to set a specific IP for the load balancer that I keep in front of the UI using MetalLb.
Hope you will merge this contribution so I don't have to modify the service after the creation :)
Thank you again for your work!
Best
Riccardo