Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added defaultDiskSelector to default storage class #162

Open
wants to merge 5 commits into
base: v1.6.x
Choose a base branch
from

Conversation

OnekO
Copy link

@OnekO OnekO commented Jul 6, 2024

This pull request add an option to set a disk selector on the default storage class.

OnekO added 5 commits July 6, 2024 17:16
Added diskSelector option to default storageClass

Signed-off-by: Karlos <[email protected]>
Added defaultDiskSelector to allow setting a disk selector on default storage class

Signed-off-by: Karlos <[email protected]>
Added defaultDiskSelector.

Signed-off-by: Karlos <[email protected]>
Signed-off-by: Karlos <[email protected]>
Fixed wrong desc

Signed-off-by: Karlos <[email protected]>
Copy link
Member

@derekbit derekbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution.

@derekbit
Copy link
Member

derekbit commented Jul 6, 2024

Can you update https://github.com/longhorn/longhorn master branch?
We will backport to v1.6.x. Thank you.

@OnekO
Copy link
Author

OnekO commented Jul 6, 2024

Can you update https://github.com/longhorn/longhorn master branch? We will backport to v1.6.x. Thank you.

Done, thx for your job.

@innobead
Copy link
Member

innobead commented Jul 7, 2024

Thanks for the contribution. This repo is only for release purpose. For any chart contribution, you need to contribute PRs to longhorn/longhorn repo instead and the code will be automatically synced to this repo during release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants