Fix autocomplete onChange functionality when freeSolo is active #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@lookfirst I would like if you could review this PR, and give some feedback for it. Is it good to be merged or I missed something ? |
|
@tcvetkoska Sorry about that, I've been busy with a remodel of my house! =( I like that you modified things to only work on freeSolo. I'd feel a lot more comfortable with this code if you'd also add a unit test as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had issue with onChange functionality on the autocomplete component when freeSolo mode is active.
The issue was that the form was not detecting and keeping the typed changes, also the validation was not working correctly. The validation was working only onClick - the select functionality.