golint fixes (#270)

.golangci.yml

@@ -8,12 +8,12 @@ linters:
     - bodyclose
     - containedctx
     - contextcheck
+    - copyloopvar
     - durationcheck
     - errcheck
     - errname
     - errorlint
     - exhaustive
-    - exportloopref
     - forcetypeassert
     - funlen
     - gochecknoglobals
@@ -24,7 +24,6 @@ linters:
     - godot
     - gofmt
     - goimports
-    - gomnd
     - goprintffuncname
     - gosec
     - gosimple
@@ -34,6 +33,7 @@ linters:
     - maintidx
     - makezero
     - misspell
+    - mnd
     - nakedret
     - nestif
     - nilerr
@@ -93,7 +93,7 @@ issues:
       linters:
         - wrapcheck # errors are wrapped in other functions
         - gocognit # the main function can have bigger complexity
-        - nestif  # the main function can have bigger complexity
+        - nestif # the main function can have bigger complexity
         - funlen # the main function can have bigger complexity
         - gocyclo # the main function can have bigger complexity
     - path: pkg/aws/nodegroups.go

go.mod

@@ -1,6 +1,6 @@
 module github.com/loomhq/eks-ng-ami-updater
 
-go 1.21
+go 1.23
 
 require github.com/rs/zerolog v1.33.0
 

pkg/aws/ami.go

@@ -126,7 +126,7 @@ func IsLastAmiOldEnough(skipNewerThan uint, nodegroup NodeGroup, today time.Time
 		return false, fmt.Errorf("region: %s, cluster: %s, nodegroup: %s : %w", nodegroup.Region, nodegroup.ClusterName, nodegroup.ClusterName, err)
 	}
 
-	hoursToSkip := -24 * time.Duration(skipNewerThan) * time.Hour
+	hoursToSkip := -24 * time.Duration(skipNewerThan) * time.Hour //nolint:gosec // no overflow risk
 	criticalDay := today.Add(hoursToSkip).UTC()
 
 	logWithContext.Debug().Time("criticalDay", criticalDay).Uint("skipNewerThan", skipNewerThan).

pkg/aws/ami_test.go

@@ -149,8 +149,6 @@ func TestIsLastAmiOldEnough(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
-
 		fmt.Printf("test: %s\n", test.name)
 		awsSsm := testSsm{
 			OutputGetParameter: &test.mockedOutputGetParameterSsm,

pkg/aws/clusters_test.go

@@ -47,8 +47,6 @@ func TestGetClusters(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
-
 		fmt.Printf("test: %s\n", test.name)
 		awsEks := testEks{OutputListClusters: &test.mockedOutput}
 

pkg/aws/nodegroups_test.go

@@ -49,8 +49,6 @@ func TestGetNodegroupsFromCluster(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
-
 		fmt.Printf("test: %s\n", test.name)
 		awsEks := testEks{OutputListNodegroups: &test.mockedOutput}
 

pkg/aws/regions_test.go

@@ -63,8 +63,6 @@ func TestGetRegionsToCheck(t *testing.T) {
 	}
 
 	for _, test := range tests {
-		test := test
-
 		fmt.Printf("test: %s\n", test.name)
 		awsEc2 := testEc2{OutputRegions: &test.mockedOutput}
 		regionsVar := test.regionsVar

pkg/updater/updater.go

@@ -138,7 +138,6 @@ func UpdateAmi(dryrun bool, skipNewerThanDays uint, regionsVar, nodegroupsVar []
 	}
 
 	for _, nodegroup := range nodegroups {
-		nodegroup := nodegroup
 		errorGroup.Go(func() error {
 			return aws.AmiUpdate(nodegroup.Region, nodegroup.ClusterName, nodegroup.NodegroupName, dryrun, ctx)
 		})