fixup!: apply feedback

loopbackio · Jun 29, 2020 · 7bf25e4 · 7bf25e4
1 parent b545786
commit 7bf25e4
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 6 deletions.
diff --git a/packages/rest/src/coercion/coerce-parameter.ts b/packages/rest/src/coercion/coerce-parameter.ts
@@ -170,7 +170,7 @@ async function coerceObject(
 ) {
   const data = parseJsonIfNeeded(input, spec);
 
-  if (data === undefined || data === null) {
+  if (data == null) {
     // Skip any further checks and coercions, nothing we can do with `undefined`
     return data;
   }
@@ -185,7 +185,7 @@ async function coerceObject(
       data,
       schema,
       {},
-      {...options, coerceTypes: true, position: 'parameter'},
+      {...options, coerceTypes: true, source: 'parameter'},
     );
   }
 

diff --git a/packages/rest/src/types.ts b/packages/rest/src/types.ts
@@ -116,7 +116,7 @@ export interface ValueValidationOptions extends RequestBodyValidationOptions {
    * Where the data comes from. It can be 'body', 'path', 'header',
    * 'query', 'cookie', etc...
    */
-  position?: string;
+  source?: string;
 }
 
 /**

diff --git a/packages/rest/src/validation/request-body.validator.ts b/packages/rest/src/validation/request-body.validator.ts
@@ -72,7 +72,7 @@ export async function validateRequestBody(
   options = {coerceTypes: !!body.coercionRequired, ...options};
   await validateValueAgainstSchema(body.value, schema, globalSchemas, {
     ...options,
-    position: 'body',
+    source: 'body',
   });
 }
 
@@ -155,7 +155,7 @@ export async function validateValueAgainstSchema(
     const validationResult = await validate(value);
     // When value is optional & values is empty / null, ajv returns null
     if (validationResult || validationResult === null) {
-      debug('Value passed AJV validation.');
+      debug(`Value from ${options.source} passed AJV validation.`);
       return;
     }
   } catch (error) {
@@ -176,7 +176,7 @@ export async function validateValueAgainstSchema(
   }
 
   // Throw invalid request body error
-  if (options.position === 'body') {
+  if (options.source === 'body') {
     const error = RestHttpErrors.invalidRequestBody();
     addErrorDetails(error, validationErrors);
     throw error;