Skip to content

Commit

Permalink
Deprecated FwLifecycleAwareVideoFeedView
Browse files Browse the repository at this point in the history
Update native sdk version to 6.16.2
  • Loading branch information
xiaoslin91 committed Dec 18, 2024
1 parent 42e064b commit 384afac
Show file tree
Hide file tree
Showing 13 changed files with 19 additions and 17 deletions.
2 changes: 1 addition & 1 deletion compose/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ dependencies {
debugImplementation("androidx.compose.ui:ui-test-manifest")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion feed_integration/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import com.firework.example.feedintegration.R
import com.firework.videofeed.FeedItemClickListener
import com.firework.videofeed.FeedViewStateListener
import com.firework.videofeed.FwLifecycleAwareVideoFeedView
import com.firework.videofeed.FwVideoFeedView

class FeedListAdapter(
private val values: List<ListItem>,
Expand Down Expand Up @@ -60,14 +61,14 @@ class FeedListAdapter(
}

inner class FeedItemViewHolder(view: View) : BaseViewHolder(view) {
private var feedView: FwLifecycleAwareVideoFeedView? = null
private var feedView: FwVideoFeedView? = null

override fun bind(item: ListItem) {
// This check is needed to avoid calling init() every time view goes in and out of the view port
if (feedView == null) {
val feedView: FwLifecycleAwareVideoFeedView =
view.findViewById<FwLifecycleAwareVideoFeedView?>(R.id.feedView).apply {
init((item as FeedViewItem).viewOptions, lifecycle)
val feedView: FwVideoFeedView =
view.findViewById<FwVideoFeedView?>(R.id.feedView).apply {
init((item as FeedViewItem).viewOptions)
setOnErrorListener(onFeedErrorListener)
setOnFeedItemClickListener(onFeedItemClickListener)
setOnFeedViewStateListener(onFeedViewStateListener)
Expand Down
5 changes: 3 additions & 2 deletions feed_integration/app/src/main/res/layout/feed_list_item.xml
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<com.firework.videofeed.FwLifecycleAwareVideoFeedView xmlns:android="http://schemas.android.com/apk/res/android"
<com.firework.videofeed.FwVideoFeedView xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:app="http://schemas.android.com/apk/res-auto"
android:id="@+id/feedView"
android:layout_width="match_parent"
android:layout_height="150dp"
app:fw_playIconWidth="25dp"
app:fw_showPlayIcon="true" />
app:fw_showPlayIcon="true"
app:fw_feedAutoplay="true"/>
2 changes: 1 addition & 1 deletion feed_resources/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion language/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion multi_host_livestream/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion picture_in_picture/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion share_link/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion shopping/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion single_host_livestream/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion story_block/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down
2 changes: 1 addition & 1 deletion view_options/app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ dependencies {
implementation("com.github.bumptech.glide:glide:4.16.0")

// Firework SDK
val fireworkBomVersion = "2024.12.12"
val fireworkBomVersion = "2024.12.18"
implementation(platform("com.firework:firework-bom:$fireworkBomVersion"))
implementation("com.firework:sdk")
implementation("com.firework.external.imageloading:glide") // Glide (optional image loader)
Expand Down

0 comments on commit 384afac

Please sign in to comment.