Update IcoParser.php to detect BMP files #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With newer versions of PHP, the imagecreatefromstring parses BMP files as well as PNG. The same function being used for PNG processing now works on BMP. I added detection code for BMP to the isSupportedBinaryString() and parse() functions PNG detection, and renamed the function and variables to reflect that it may not just be PNG files anymore.
I verified this on the php.net website, which uses a BMP as it's favicon.
For my implementation of the library, I am using my code to download the ico. I send it to icofileloader as a string.
This should address Issue #16