Skip to content
This repository has been archived by the owner on Aug 22, 2022. It is now read-only.

Update lrInfiniteScroll.js #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orszaczky
Copy link

In my tests handler always evaluated to noop, so the function never got called.
To get it working without an isolate scope, I used $apply() directly in the promise timeout function, which $eval()s its argument against the scope.

In my tests handler always evaluated to noop, so the function never got triggered.
To get it working without an isolate scope, I used $apply() directly in the promise timeout function, which $eval()s its argument against the scope.
@lorenzofox3
Copy link
Owner

sounds like a scope issue, plunker ?

@lorenzofox3
Copy link
Owner

lol, this is not what I call a running example. Seriously, what do you want me to do with a bunch of HTLM tags ? :)
Add the javascript at least the basics to be able to see the problem (I don't need to see all your application),
Just let the part of the code useful to reproduce the problem (remove the noise), for example: we don't need all the style attributes on the images tags

You'll see, often when people try to set up a real and clean plunker(or jsfiddle) to reproduce the issue...the issue disappear !

@hirbod
Copy link

hirbod commented Dec 17, 2014

I had the same problem..

 <section class="gossip" lr-infinite-scroll="loadMore()">

doesn't load anything.

 <section class="gossip" lr-infinite-scroll="loadMore">

works perfectly (without ( ))

Maybe I have to try this PR, but actually, everything works at the moment - even if I don't understand why.

@hirbod
Copy link

hirbod commented Dec 17, 2014

I can confirm: this PR fixed my issues. Please merge it. Angular 1.3.0

@wajih775
Copy link

working absolutely fine.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants