Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

centerMode option added #763

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

nishantuie
Copy link

Added centerMode option to enable centerMode functionality which is missing in current day implementation.

@nishantuie nishantuie changed the title Feature/center mode centerMode option added Jun 14, 2019
@nishantuie nishantuie mentioned this pull request Jun 14, 2019
Copy link
Collaborator

@Saturate Saturate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.

Thanks for contributing!

static/app.css Outdated Show resolved Hide resolved
@nishantuie nishantuie requested a review from Saturate November 8, 2019 06:11
@Ankitpatel08
Copy link

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.

Thanks for contributing!

image

Verified, Works fine with variable width slides and great to have firstSlideLeftAligned feature.

@nishantuie
Copy link
Author

nishantuie commented Nov 12, 2019

Just took a quick look, you have some uncommented code included. I'll dig a little deeper soon, but I am quite busy at the current time. If people want to test and confirm that it works, that will also help me.
Thanks for contributing!

Verified, Works fine with variable width slides and great to have firstSlideLeftAligned feature.

Thanks for checking. Glad to know it will be a help.

@Saturate
Copy link
Collaborator

Looks, good. But my computer died, I'll get a new one the 21th so it's hard for me to make the final things - it's not forgotten :)

@nishantuie
Copy link
Author

nishantuie commented Nov 19, 2019 via email

@nishantuie
Copy link
Author

Looks, good. But my computer died, I'll get a new one the 21th so it's hard for me to make the final things - it's not forgotten :)

@Saturate Thanks for reviewing.

@GiancarlosIO
Copy link

👀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants