Issue #301 Fix loading tmx tilesets of individual tiles #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Get this error too, thanks for fix! |
|
No problem! Just in case you run into it, I also found after this fix that objects didn't properly grab the usertype from the associated tile type in the tileset. I made made an easy fix for it in my fork, but it's not relevant to the main branch until this PR is accepted so it'll just live their for now. |
Closed
r1chardj0n3s
requested changes
Aug 11, 2019
| if value.isdigit(): | ||
| value = int(value) | ||
| tile.properties[name] = value | ||
| except (KeyError, AttributeError): |
There was a problem hiding this comment.
This is an exceptionally broad try block, those two errors could come from any number of lines above. What specific key and attribute access errors are being caught here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #301
If a tile element is encountered load_tmx() will attempt to associate the tile properties with an element of tileset as normal unless a KeyError or AttributeError is encountered. If accessing a tileset causes an attribute error (because there was no previous image element that created the tileset with from_atlas()) or if it causes a key error (because there was no tile with the gid expected), then we assume this is a new tile and add it as an individual tile to the tileset.