reset stats + cache before running #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
sidjha1
reviewed
Jan 26, 2025
| @@ -540,6 +540,9 @@ def test_disable_operator_cache(setup_models, model): | |||
| lm = LM(model="gpt-4o-mini", cache=cache) | |||
| lotus.settings.configure(lm=lm, enable_cache=False) | |||
|
|
|||
| lm.reset_cache() | |||
There was a problem hiding this comment.
Is there a reason why this does not clear the cache properly?
There was a problem hiding this comment.
Oh I think its because when we initialize our model in the tests, I am defining it as lm=LM(model='gpt-40-mini', cache=cache) rather than lm = setup_models[model] since we needed to include the cache arg. So the lm instance may not be using the def print_usage_after_each_test(setup_models):
sidjha1
approved these changes
Feb 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resetting cache before the test is run