Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add street names as street signs at intersections #110

Closed
wants to merge 1 commit into from

Conversation

IAmStoxe
Copy link

@IAmStoxe IAmStoxe commented Jan 1, 2025

Add an option to include street names as street signs at intersections in the application.

  • HTML Changes:

    • Add a new checkbox option labeled "Add Street Names" to the settings modal in gui-src/index.html.
  • JavaScript Changes:

    • Add an event listener for the "Add Street Names" checkbox in gui-src/js/main.js.
    • Modify the startGeneration function to pass the "Add Street Names" option to the backend.
  • Rust Changes:

    • Add a new argument add_street_names to the Args struct in src/args.rs.
    • Update the run method to handle the new add_street_names argument.
    • Add a new function generate_street_signs in src/element_processing/street_signs.rs to handle adding street names as street signs.
    • Modify the generate_highways function in src/element_processing/highways.rs to call generate_street_signs if the add_street_names option is enabled.
    • Add a new module street_signs in src/element_processing/mod.rs.
    • Modify the gui_start_generation function in src/main.rs to accept the new add_street_names argument.

Add an option to include street names as street signs at intersections in the application.

* **HTML Changes:**
  - Add a new checkbox option labeled "Add Street Names" to the settings modal in `gui-src/index.html`.

* **JavaScript Changes:**
  - Add an event listener for the "Add Street Names" checkbox in `gui-src/js/main.js`.
  - Modify the `startGeneration` function to pass the "Add Street Names" option to the backend.

* **Rust Changes:**
  - Add a new argument `add_street_names` to the `Args` struct in `src/args.rs`.
  - Update the `run` method to handle the new `add_street_names` argument.
  - Add a new function `generate_street_signs` in `src/element_processing/street_signs.rs` to handle adding street names as street signs.
  - Modify the `generate_highways` function in `src/element_processing/highways.rs` to call `generate_street_signs` if the `add_street_names` option is enabled.
  - Add a new module `street_signs` in `src/element_processing/mod.rs`.
  - Modify the `gui_start_generation` function in `src/main.rs` to accept the new `add_street_names` argument.
@benjamin051000
Copy link
Contributor

What's the difference between this and #109 ?

@louis-e louis-e closed this Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants