Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GitHub Actions to support GitHub Container Registry #320

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

webysther
Copy link

@webysther webysther commented Jan 7, 2025

Closes #319

By opening a pull request, I certify that I hold the intellectual property of the code I am submitting, and I am granting the initial authors of WBO a perpetual, worldwide, non-exclusive, royalty-free, and irrevocable license to this code.

@webysther webysther changed the title Update deploy.yml to support ghcr Update GitHub Actions to support GitHub Container Registry Jan 7, 2025
@lovasoa
Copy link
Owner

lovasoa commented Jan 7, 2025

hmm, I'm not sure, but I don't think this is how it is supposed to work?

You are never supposed to create GitHub tokens for gh actions, they should use their own temporary token, which is more secure. Shouldn't they?

@webysther
Copy link
Author

hmm, I'm not sure, but I don't think this is how it is supposed to work?

You are never supposed to create GitHub tokens for gh actions, they should use their own temporary token, which is more secure. Shouldn't they?

Yeap, I forgot, the GITHUB_TOKEN you don't need to create.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker image to ghcr
2 participants