Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uart1 is never initialized CHERIoT RTOS. So when you have a small transmit buffer the RTOS test suite fails (as it's stderr test uses uart1 and it fills up the buffer and waits forever for it to send something so it can put more character into the buffer). I've opened an upstream issue for this: CHERIoT-Platform#317
This side steps the problem by allowing us to force stderr to the same UART as stdout. I think we'll want this setup on Sonata anyway as we'll have one fixed UART (for debug, stdout and stderr) and 2 or 3 pin muxable UARTs and it's not appropriate to push stderr over the pin muxable ones by default.
Ideally we'll upstream this change as well.