Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stdio stderr is stdout #14

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Conversation

GregAC
Copy link

@GregAC GregAC commented Oct 17, 2024

uart1 is never initialized CHERIoT RTOS. So when you have a small transmit buffer the RTOS test suite fails (as it's stderr test uses uart1 and it fills up the buffer and waits forever for it to send something so it can put more character into the buffer). I've opened an upstream issue for this: CHERIoT-Platform#317

This side steps the problem by allowing us to force stderr to the same UART as stdout. I think we'll want this setup on Sonata anyway as we'll have one fixed UART (for debug, stdout and stderr) and 2 or 3 pin muxable UARTs and it's not appropriate to push stderr over the pin muxable ones by default.

Ideally we'll upstream this change as well.

This is useful for boards that may have a uart1 but don't want it being
used for stderr.
@GregAC GregAC requested a review from HU90m October 17, 2024 14:40
Copy link

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable to me.

@HU90m HU90m merged commit 34fc63b into lowRISC:sonata Oct 17, 2024
@GregAC GregAC deleted the stdio_stderr_is_stdout branch October 17, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants