[sw] Add a CMake option to choose whether to halt the core upon program termination #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
engdoreis
reviewed
Jul 5, 2023
There was a problem hiding this comment.
Thanks for tackling this issue.
After these changes, we will need to specify the HALT_SIM_WHEN_EXIT flag every time when building for Software to be used in the simulation?
I would prefer having a multi target approach, which could be done by have a flag called TARGET=<FPGA|VERILATOR> and possibly always build both targets and the user chooses which binary should be loaded.
|
Agreed. I'll update and rebase my changes on top of pull request #46 that has just been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #48 by adding a CMake option to choose whether to halt the core upon program termination