Disable tests when building verible #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing takes ~30m to run locally on a laptop, and there's not a huge amount of benefit in running the tests for us. Maybe in the future we could have a job that builds for our cache which explicity enables running the tests. Signed-off-by: Harry Callahan <[email protected]>
nbdd0121
reviewed
Jul 25, 2024
| }; | ||
|
|
||
| patches = []; | ||
|
|
||
| bazel = bazel_6; | ||
|
|
||
| # Disable tests (takes ~30m to run locally on a laptop) | ||
| bazelTestTargets = []; |
There was a problem hiding this comment.
Does dontCheck = true work?
There was a problem hiding this comment.
Nope, something to do with the implementation of buildBazelPackage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When bumping flake.lock locally, after building verible the testing phase takes ~30m to run locally on a laptop. There's also not a huge amount of benefit in running the tests for us when we are statically pinning the version. Maybe in the future when building for our cache we can explicitly enable running the tests.