Fix licence checker paths in Bazel 7 onwards #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks that the rule is usable, but doesn't necessary test that it's checking the correct files. Signed-off-by: James Wainwright <[email protected]>
jwnrt
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 7 was unable to find the
licence-checkerthe first time it was used by the rule, but could in subsequent rules. Turns out we were referencing it using.pathwhich is relative to the repository root. This path isn't always available due to weird symlink business that Bazel does.Instead, this PR changes it to use
.short_pathwhich is relative to the runfiles directory that Bazel executes the rule in. This is what the Bazel documentation tells you to use for accessing runfiles: https://bazel.build/rules/lib/builtins/File.html#pathI've also added a test which makes use of the rule to catch breakages.
I've removed the hack we were using before since it's no longer needed.