Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware Access Control and Sonata Software Book #31

Merged
merged 9 commits into from
Aug 31, 2024

Conversation

HU90m
Copy link
Member

@HU90m HU90m commented Aug 30, 2024

No description provided.

@HU90m HU90m changed the title Hardware Access Control and Sonata Software Book access control Hardware Access Control and Sonata Software Book Aug 30, 2024
@HU90m HU90m marked this pull request as draft August 30, 2024 21:02
@HU90m HU90m marked this pull request as ready for review August 31, 2024 15:41
Copy link
Contributor

@marnovandermaas marnovandermaas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for walking me through these changes. Approving so that we can get this in and iterate over it later. I'll do a more detailed review and run through later and propose changes in a follow up PR if necessary.

@HU90m HU90m merged commit b1899da into lowRISC:main Aug 31, 2024
1 check passed
Copy link

@johngt johngt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some changes suggested

README.md Show resolved Hide resolved
# Exploring CHERIoT RTOS
## CHERIoT RTOS Orientation
All the software in this repository runs on the CHERIoT RTOS, which is pulled into this repository as a submodule at [`cheriot-rtos`].
The [CHERIoT Programmer's Guide] contains most of what a programmer would need to know to use the RTOS.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a GitHub equivalent repo link for this

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, here: https://github.com/CHERIoT-Platform/book
But we don't have to link that here right?

doc/exploring-cheriot-rtos.md Show resolved Hide resolved
doc/guide/running-software.md Show resolved Hide resolved
doc/guide/running-software.md Show resolved Hide resolved
exercises/hardware_access_control/README.md Show resolved Hide resolved
exercises/hardware_access_control/README.md Show resolved Hide resolved
exercises/hardware_access_control/README.md Show resolved Hide resolved
exercises/hardware_access_control/README.md Show resolved Hide resolved
exercises/hardware_access_control/README.md Show resolved Hide resolved
@HU90m
Copy link
Member Author

HU90m commented Sep 3, 2024

Thank you very much @AlexJones0 and @johngt , these are great spots/suggestions.

Currently blocked on #34 , before I can make the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants