Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pleroma federation fixes and hidden RSVP functionality #129

Merged
merged 7 commits into from
Feb 6, 2024

Conversation

lowercasename
Copy link
Owner

@lowercasename lowercasename commented Feb 5, 2024

Bugfixes

This PR fixes the longstanding issues with Pleroma federation, which all stem from the fact that Pleroma generally has a stricter interpretation of the ActivityPub spec, and in other ways just has its own ideas about things like Question objects, but Gathio's AP implementation wasn't originally developed against a Pleroma instance. This fixes:

  • The bug where RSVP Polls couldn't be replied to from Pleroma (because Pleroma expects to see the number of current votes for a poll in the poll object)
  • A bug where Gathio wouldn't receive and repost messages mentioning the event Actor when sent from a Pleroma instance
  • One click unattending also works.

There may still be bugs with:

  • Unboosting Pleroma boosts when a comment is deleted on Gathio
  • Replying to Pleroma DMs with a message explaining that the user should mention the event actor instead

These will be handled in a separate PR, if necessary.

Features

This also starts the AP migration to Typescript, and adds a new feature - optionally hidden RSVPs! Currently this only accessible via ActivityPub interaction, where in the RSVP poll you can now choose one of three options:

Screenshot 2024-02-05 at 21 41 47

If you choose to be hidden from the public list, the public list will look like this for regular users:

Screenshot 2024-02-05 at 21 43 27

...and like this for the event editors:

Screenshot 2024-02-05 at 21 43 34

To do

  • Allow hidden RSVP from Gathio UI

@lowercasename lowercasename force-pushed the rk/fix-pleroma branch 2 times, most recently from e49547d to 461e271 Compare February 5, 2024 21:06
@lowercasename lowercasename marked this pull request as ready for review February 5, 2024 21:47
@lowercasename lowercasename changed the title Pleroma federation fixes Pleroma federation fixes and hidden RSVP functionality Feb 5, 2024
@lowercasename lowercasename merged commit 9e249e5 into main Feb 6, 2024
2 checks passed
@dariusk
Copy link
Contributor

dariusk commented Feb 6, 2024

Incredible work here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants