-
Notifications
You must be signed in to change notification settings - Fork 0
3 add tests to partner request spec #12
base: master
Are you sure you want to change the base?
Conversation
fixed rubo cop
fixed style again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really close to being done I think! The main piece remaining is then attempting to modify the partner object to violate the assumptions and verify it's no longer valid. For example, for the third test, you may want to remove the documents and verify that valid?
then returns false.
@mdworken are you saying I should change to code in the partner request model (see screenshot)l? Or should I simply test to see if the tests fail without editing the model? |
spec/models/partner_request_spec.rb
Outdated
end | ||
end | ||
|
||
describe "a partner must contain" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
describe
blocks can contain multiple it
blocks, so you don't need a second one here.
@Randond what I'm trying to get at is within the test you should change the attribute, then verify that |
@Randond you'll need to re-merge master into this branch, as it's out of date now. |
All tests pass. Do I need to also test the conditions if the conditions are not met?
Checklist:
-->
Resolves #7
Description
Type of change
How Has This Been Tested?
Screenshots