Skip to content
This repository has been archived by the owner on Mar 8, 2020. It is now read-only.

README updates, Job System Form Update: AWS SES, S3 #53

Merged
merged 17 commits into from
May 17, 2018
Merged

Conversation

tmloupe
Copy link

@tmloupe tmloupe commented Dec 19, 2017

#12, #31, #32, #33
To test this out you'll need your own AWS accounts. App.rb function has a placeholder for a cc email. Follow instructions in readme: just put the proper variables inside the .env file. The .env.example has been updated to reflect these changes.

At first, this pull request was a simple emailer. It has evolved into the hub for AWS services on the job form. Additionally cleans up some of the README files. Likely too much for one pull request, but I had to update many things anyway.

Pretty much done. Tweaking necessary for future opportunity center emailing, but that can be a simple parameter change.

What's left to do

  • Manage page integration. We want to be able to dynamically grab opportunity centers for the emailer system.

@tmloupe tmloupe changed the title AWS SES for job system form Job System Form Update: AWS SES, S3 Dec 20, 2017
@tmloupe tmloupe changed the title Job System Form Update: AWS SES, S3 README updates, Job System Form Update: AWS SES, S3 Dec 20, 2017
@@ -0,0 +1,3 @@
language: ruby
rvm:
- 2.2.5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis still needs some config. Likely a dummy .env file that matches what it's supposed to do to setup the database for testing.

Copy link
Member

@nihonjinrxs nihonjinrxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks pretty good.

  • Verified database setup and migrations work as expected.
  • Verified data is getting where it's supposed to get.
  • Verified email goes out to client as expected (when address is verified, since we're in testing mode -- that limitation goes away when we real SES is purchased).

Note: I couldn't verify Opp Center notification emails go out, but it looks from the logs like they should.

A couple minor items I noticed, which can be fixed later:

  • Ruby version (2.2.5) is pretty old now, and could likely use an update. 2.4.5 or 2.5.1 is likely a better choice, but that will take some effort to do, as there will be upgrade issues.
  • Deprecation notice in the logs after loading app.js:
::1 - - [17/May/2018:00:52:15 -0500] "GET /assets/app.js HTTP/1.1" 304 - 0.1885
DEPRECATION WARNING on line 119 of /Users/ted/code/ryan/loyola/workforwardnola/assets/style/main.scss:
Extending a compound selector, a:link, is deprecated and will not be supported in a future release.
See https://github.com/sass/sass/issues/1599 for details.
  • Travis CI is still having problems despite me adding a config file and a :default Rake task. Likely needs a .env with something it recognizes for DB setup, and possibly needs to know what to do to setup the DB. Need to look at Travis docs for that.

Ready to merge.

@nihonjinrxs
Copy link
Member

@tmloupe PR approved. Merge at will.

@tmloupe tmloupe merged commit 38e355d into master May 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants