Remove precompilation and AlphaStableDistributions.jl dependency #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrnv
changed the title
Repository owner
deleted a comment from
codecov-commenter
Oct 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #37 +/- ##
===========================================
- Coverage 66.34% 48.90% -17.44%
===========================================
Files 20 21 +1
Lines 309 321 +12
===========================================
- Hits 205 157 -48
- Misses 104 164 +60
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on alphastabledistributions.jl which is causing a lot of load time and compile time to occur,, while we really do not need 99% of it but only one function.
Sadly, copying the function here does not feel like the right thing to do since it's deduplicating code so I dont know yet what will be the outcome of this.