Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Base.rand #41

Merged
merged 12 commits into from
Oct 26, 2023
Merged

Removing Base.rand #41

merged 12 commits into from
Oct 26, 2023

Conversation

lrnv
Copy link
Owner

@lrnv lrnv commented Oct 26, 2023

Less code is always better, and the functionlity is already provided by Distributions.jl

See https://discourse.julialang.org/t/required-methods-to-sample-a-multivariate-distribution/105443

Santymax98 and others added 9 commits October 26, 2023 00:56
… bivariate Plackett Copula, calculation of the CDF and PDF functions, the random sample generator and the Spearman Rho calculation. Additionally, I added some testing these functions in biv_plackett.jl.
… bivariate Plackett Copula, calculation of the CDF and PDF functions, the random sample generator and the Spearman Rho calculation. Additionally, I added some testing these functions in biv_plackett.jl.
@lrnv lrnv changed the title Removing Base.rand implemntations as they are useless now Removing Base.rand Oct 26, 2023
@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #41 (666320b) into main (810ebb9) will increase coverage by 6.44%.
Report is 9 commits behind head on main.
The diff coverage is 50.00%.

❗ Current head 666320b differs from pull request most recent head eafd98a. Consider uploading reports for the commit eafd98a to get more accurate results

@@            Coverage Diff             @@
##             main      #41      +/-   ##
==========================================
+ Coverage   67.70%   74.14%   +6.44%     
==========================================
  Files          21       21              
  Lines         322      294      -28     
==========================================
  Hits          218      218              
+ Misses        104       76      -28     
Files Coverage Δ
src/ArchimedeanCopula.jl 86.95% <ø> (+11.48%) ⬆️
src/ArchimedeanCopulas/IndependentCopula.jl 0.00% <ø> (ø)
src/Copula.jl 100.00% <ø> (ø)
src/EllipticalCopula.jl 100.00% <ø> (+16.66%) ⬆️
src/MiscellaneousCopulas/MCopula.jl 0.00% <ø> (ø)
src/MiscellaneousCopulas/SurvivalCopula.jl 60.71% <ø> (+7.58%) ⬆️
src/MiscellaneousCopulas/WCopula.jl 0.00% <ø> (ø)
src/SklarDist.jl 100.00% <ø> (+16.66%) ⬆️
src/univariate_distributions/AlphaStable.jl 96.00% <100.00%> (ø)
src/EmpiricalCopula.jl 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lrnv lrnv merged commit 7d2984d into main Oct 26, 2023
@lrnv lrnv deleted the removing_useless_base_rand branch November 8, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants