Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Raftery copula #91
Raftery copula #91
Changes from all commits
d142f2b
b914806
49bcc95
30fcb75
8e1aa29
db385c2
59c18cf
00bc7a3
fd9a3db
e6d9ddb
ec65d3f
0c6c06d
c86bfb1
0ce8dcd
1920d01
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 60 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L60
Check warning on line 62 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L62
Check warning on line 66 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L64-L66
Check warning on line 68 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L68
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pdf was not ran by the tests. Could you add a test to check if the pdf is, at least, not producing errors ? If possible, could you add another one that checks that the values produced are the right ones ? Maybe by computing one or two values by hand for specific parameters in dimension two ?
In particular, I am worried that
term_denominator
andterm_numerator
are negative, which will make the log produce an error. adding these tests is a very good way of knowing if it is ok or not :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to do it now
Check warning on line 70 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L70
Check warning on line 93 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L90-L93
Check warning on line 102 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L95-L102
Check warning on line 104 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L104
Check warning on line 106 in src/MiscellaneousCopulas/RafteryCopula.jl
Codecov / codecov/patch
src/MiscellaneousCopulas/RafteryCopula.jl#L106