Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry with delay on some errors #18

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

legioner0
Copy link

Implements retry with delay in case if Icinga2 server returns 503 Icinga is reloading or low-level errors, like Connection refused.

dakota-marshall and others added 8 commits June 26, 2024 20:08
* Create CI Actions

* add container ps for debugging

* add container ID step

* fix typo

* Use container ID

* add sleep

* unescape variable

* update variables

* remove quotes aswell

* correct env variable

* Update README.md badges
retry on 503
@dakota-marshall
Copy link

Hey there! This repo hasn't seen activity in over 4 years, I think it's safe to say this project has probably been abandoned.

I'm not sure if this is bad manners or not, but I have been working on this repo for a month or so by adding support for the package config management endpoint to add support for Zone and Endpoint objects over on my fork dakota-marshall/go-icinga2-api. I also implemented the fix for creating host variables that I have waiting to merge in here. My goal is to try and pitch that the downstream Terraform provider switch to my repo eventually, so I can implement these updates and improvements can be made to the provider.

I'd love to have you merge your changes in over there if you're interested? This was actually on my todo list lol.

@legioner0
Copy link
Author

Hello. Nice to here that someone, except me, try to enhance terraform-provider-icinga2.

Sure. I'll made a PR to your fork.

dakota-marshall and others added 5 commits September 4, 2024 00:49
* (WIP) Add Endpoint config

* Add dev flake

* feat: Add CreatePackage method and supporting tests

* feat:Add Create and Delete package method

* feat: Add package stage create method

* test: remove active stage test

* add devle debugger to flake

* run tests sequentially for package stage tests

* feat: add package stage methods, remove broken endpoint tests

* ci: add ci workflow

* fix: Remove DeletePackageStage as API doesnt handle it correctly

* test: Add get package stage error test

* test: Add additional error testing

* feat: Add CreateEndpoint method

* chore: add docker_restart for quick rebuild

* feat: Add Create and Get Endpoint methods

* fix: remove commented static password

* docs: Create CHANGELOG

* docs: Add todo for handling zones properly

* ci: Remove build action, as there is nothing to build
* retry on connect

* codestyle

* retry in new request
retry on 503

* refactor

---------

Co-authored-by: Pavel Motyrev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants