Find specific Docker tag for build #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelixTJDietrich
approved these changes
Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
#73 has issues where the necessary docker images are not built, even though they don't exist yet.
Description
Solution: Properly detect if the images already exist or not. Before, the tag wasn't taken into consideration by accident. Now, the specific tag of the Docker image is checked in GitHub.
Steps for Testing
Note that the build step to find images to build correctly identifies the image as missing: https://github.com/ls1intum/Athena/actions/runs/5849504932/job/15857908702?pr=74#step:3:45
Also, note that merging the branch of this PR into #73 fixes the issue there: All missing images are now built: https://github.com/ls1intum/Athena/actions/runs/5849540999/job/15857980555
(you can also check that the deployment now works correctly)
Screenshots