feat: Connect PR data in client #68
+346
−47
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,16 @@ | ||
| { | ||
| "java.debug.settings.hotCodeReplace": "auto", | ||
| "java.configuration.updateBuildConfiguration": "interactive", | ||
| "sqltools.connections": [ | ||
| { | ||
| "previewLimit": 50, | ||
| "server": "localhost", | ||
| "port": 5432, | ||
| "driver": "PostgreSQL", | ||
| "name": "application-service-dev", | ||
| "password": "helios", | ||
| "username": "helios", | ||
| "database": "helios" | ||
| } | ||
| ] | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
|
There was a problem hiding this comment. IMO this loading doesn't look that good, but I think it is the default one from the library 😞
For the next week maybe we can also talk about loading animation for pages, I am not sure |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| <p-table [value]="pullRequests()" [loading]="isLoading()" styleClass="p-datatable-sm"> | ||
| <ng-template pTemplate="header"> | ||
| <tr> | ||
| <th>Title</th> | ||
| <th>Draft</th> | ||
| <th>Status</th> | ||
| <th>Author</th> | ||
| <th>Assignee</th> | ||
| <th>Created</th> | ||
| </tr> | ||
| </ng-template> | ||
| <ng-template pTemplate="body" let-pr> | ||
| <tr> | ||
| <td> | ||
| <div class="flex align-items-center gap-2"> | ||
| <span class="font-bold">{{ pr.title }}</span> | ||
| <button pButton class="p-button-text p-button-sm" (click)="openPR(pr.htmlUrl)"><i-tabler name="external-link"></i-tabler></button> | ||
| </div> | ||
| </td> | ||
| <td> | ||
| <p-tag *ngIf="pr.isDraft" value="Draft" severity="secondary"> </p-tag> | ||
| </td> | ||
| <td> | ||
| <p-tag [value]="getStatus(pr)" [severity]="getStatusSeverity(pr)"> </p-tag> | ||
| </td> | ||
| <td> | ||
| <div class="flex align-items-center gap-2"> | ||
| <p-avatar [image]="pr.author.avatarUrl" shape="circle" size="normal"> </p-avatar> | ||
| <span>{{ pr.author.name }}</span> | ||
| </div> | ||
| </td> | ||
| <td> | ||
| <div class="flex align-items-center gap-2" *ngIf="pr.assignees?.length"> | ||
| <p-avatar *ngFor="let assignee of pr.assignees" [image]="assignee.avatarUrl" shape="circle" size="normal"> </p-avatar> | ||
| </div> | ||
| </td> | ||
| <td> | ||
| {{ formatDate(pr.createdAt) }} | ||
| </td> | ||
| </tr> | ||
| </ng-template> | ||
| </p-table> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| import { ComponentFixture, TestBed } from '@angular/core/testing'; | ||
|
|
||
| import { PullRequestTableComponent } from './pull-request-table.component'; | ||
|
|
||
| describe('PullRequestTableComponent', () => { | ||
| let component: PullRequestTableComponent; | ||
| let fixture: ComponentFixture<PullRequestTableComponent>; | ||
|
|
||
| beforeEach(async () => { | ||
| await TestBed.configureTestingModule({ | ||
| imports: [PullRequestTableComponent] | ||
| }) | ||
| .compileComponents(); | ||
|
|
||
| fixture = TestBed.createComponent(PullRequestTableComponent); | ||
| component = fixture.componentInstance; | ||
| fixture.detectChanges(); | ||
| }); | ||
|
|
||
| it('should create', () => { | ||
| expect(component).toBeTruthy(); | ||
| }); | ||
| }); |
|
There was a problem hiding this comment. In the initial run it creates the table but after switching tabs, the table stuck at loading state.
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,67 @@ | ||
| import { Component, inject, signal } from '@angular/core'; | ||
| import { CommonModule } from '@angular/common'; | ||
| import { TableModule } from 'primeng/table'; | ||
| import { AvatarModule } from 'primeng/avatar'; | ||
| import { TagModule } from 'primeng/tag'; | ||
| import { injectQuery } from '@tanstack/angular-query-experimental'; | ||
| import { tap } from 'rxjs'; | ||
| import { IconsModule } from 'icons.module'; | ||
| import { PullRequestControllerService, PullRequestInfoDTO } from '@app/core/modules/openapi'; | ||
|
|
||
|
|
||
| @Component({ | ||
| selector: 'app-pull-request-table', | ||
| imports: [CommonModule, TableModule, AvatarModule, TagModule, IconsModule], | ||
| templateUrl: './pull-request-table.component.html', | ||
| styles: [` | ||
| :host ::ng-deep { | ||
|
There was a problem hiding this comment. I am not an expert on this but is it ok to use |
||
| .p-avatar { | ||
| img { | ||
| width: 100%; | ||
| height: 100%; | ||
| object-fit: cover; | ||
| } | ||
| } | ||
| } | ||
| `] | ||
| }) | ||
| export class PullRequestTableComponent { | ||
| pullRequestService = inject(PullRequestControllerService); | ||
|
|
||
|
|
||
| pullRequests = signal<PullRequestInfoDTO[]>([]); | ||
| isLoading = signal(true); | ||
|
|
||
| query = injectQuery(() => ({ | ||
| queryKey: ['pullRequests'], | ||
| queryFn: () => this.pullRequestService.getAllPullRequests() | ||
| .pipe( | ||
| tap(data => { | ||
| this.pullRequests.set(data); | ||
| this.isLoading.set(false); | ||
| }) | ||
| ).subscribe(), | ||
| })); | ||
|
|
||
| getStatus(pr: PullRequestInfoDTO): string { | ||
| if (pr.isMerged) return 'Merged'; | ||
| return pr.state === 'OPEN' ? 'Open' : 'Closed'; | ||
| } | ||
|
|
||
| getStatusSeverity(pr: PullRequestInfoDTO): ('success' | 'danger' | 'info') { | ||
| if (pr.isMerged) return 'info'; | ||
| return pr.state === 'OPEN' ? 'success' : 'danger'; | ||
| } | ||
|
|
||
| formatDate(date: string): string { | ||
| return new Date(date).toLocaleDateString('en-US', { | ||
| year: 'numeric', | ||
| month: 'short', | ||
| day: 'numeric' | ||
| }); | ||
| } | ||
|
|
||
| openPR(url: string): void { | ||
| window.open(url, '_blank'); | ||
| } | ||
| } | ||
Empty file.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| <p-tabView> | ||
| <p-tabPanel header="Pull Requests"> | ||
| <app-pull-request-table></app-pull-request-table> | ||
| </p-tabPanel> | ||
| <p-tabPanel header="Branches"> Branch List view goes here </p-tabPanel> | ||
| </p-tabView> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| import { Component } from '@angular/core'; | ||
| import { PullRequestTableComponent } from '@app/components/pull-request-table/pull-request-table.component'; | ||
| import { TabViewModule } from 'primeng/tabview'; | ||
| @Component({ | ||
| selector: 'app-ci-cd', | ||
| imports: [PullRequestTableComponent, TabViewModule], | ||
| templateUrl: './ci-cd.component.html', | ||
| styleUrl: './ci-cd.component.css' | ||
| }) | ||
| export class CiCdComponent {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| export const environment = { | ||
| production: false, | ||
| serverUrl: 'http://localhost:8080', | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| export const environment = { | ||
| production: true, | ||
| serverUrl: 'https://helios.artemis.cit.tum.de', | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| export const environment = { | ||
| production: false, | ||
| serverUrl: 'http://localhost:8080', | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I increased those limits but we need to have a Github action (in the future) to check if the build passes or not. Because when I was trying, the build step was failing due to the limits.