Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thesis: Add Survey dialog #140

Merged
merged 10 commits into from
Nov 29, 2024
Merged

Thesis: Add Survey dialog #140

merged 10 commits into from
Nov 29, 2024

Conversation

FelberMartin
Copy link
Collaborator

@FelberMartin FelberMartin commented Nov 22, 2024

Problem Description

As part of my masters thesis, I want to conduct a survey of the Artemis Android app users. To make the users aware of that survey, I will display a small hint in the course overview for the duration of the survey (approx. 2 weeks). The survey will be hosted by the chair owned domain https://survey.ase.in.tum.de/.

Here are the preliminary questions: https://confluence.ase.in.tum.de/spaces/ArTEMiS/pages/232761693/Artemis+Android+Questionnaire

Changes

  • Added survey hint in the CourseOverview
  • Added survey dialog
  • Restructured CourseOverview code
    • extracted BetaHintDialog
    • extracted CourseList

Steps for testing

  • Go to the course overview page
  • Notice the survey hint
  • Click on it
  • Press "Not now" -> dialog closes
  • Click on it again
  • Press "Participate" -> for now this only takes you too a example domain in the browser
  • Navigate back to the app -> the hint is not shown anymore

Screenshots

image
image

Next steps

As soon as the survey questions and timeline is finalized

  • Add appropriate start and end dates (the survey hint will only be displayed during that period) -> DONE
  • Replace the sample with the real survey link -> DONE
  • Merge the PR
  • Create a new release

@FelberMartin FelberMartin marked this pull request as ready for review November 22, 2024 13:37
@FelberMartin FelberMartin self-assigned this Nov 22, 2024
@FelberMartin FelberMartin added the ready for review This PR can be reviewed label Nov 23, 2024
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work as expected, the link leads to the website. Only thing I noticed is that the text in the dialog. I think it would look better if it was centered, but I think it's the default for Android to have it on the left. You can try to change it (see below), but it's not necessary, the beta hint dialog is not centered as well.

@FelberMartin FelberMartin removed the ready for review This PR can be reviewed label Nov 29, 2024
@FelberMartin FelberMartin added the ready to merge This PR can be merged label Nov 29, 2024
# Conflicts:
#	app/src/main/java/de/tum/informatics/www1/artemis/native_app/android/ui/MainActivity.kt
#	feature/dashboard/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/dashboard/CoursesOverview.kt
@FelberMartin FelberMartin merged commit aafd80b into develop Nov 29, 2024
5 checks passed
@FelberMartin FelberMartin deleted the general/survey-dialog branch November 29, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready to merge This PR can be merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants