-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added missing features & enhancements #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manual testing of features
- A dropdown menu consisting of fav, hide, and mute buttons has been added for each channel (similar to iOS). -> ✅
- The channel sidebar has been grouped (e.g., exercise/lecture) with icons added for each section (similar to iOS & web). -> ✅
- The create channel screen design has been changed. Toggle buttons similar to those in the iOS app have been added, with the default option changed from announcement to unrestricted. -> ✅
- The channel search logic has been improved, now able to show channels in non-expanded sections within filtering options. ->
⚠️ The search is currently case sensitive -> case in-sensitive makes more sense to me⚠️ When searching, the keyboard currently shows the enter/newLine key (which is useless in this case) -> show "done" key instead (closing the keyboard)⚠️ Is it intended that when searching, the sections are non-collapsable? (You wrote non-expanded)
- A clear input button has been added to the search input area. -> ✅
- The section headers in the sidebar are now clickable, expanding/collapsing when pressed. -> ✅
- The message input area now includes the channel name (similar to iOS). -> ✅
- A floating action button on the communication screen has been added with a 3-option dropdown, opening the correct pages (browse, create chat, create channel). This makes navigation easier during channel creation, eliminating the need to go to the browse page (similar to iOS). -> ✅
- In the browse channel view, channels the user is a member of are now visible (similar to iOS). -> ✅
- A join button has been added to channels in the browse view that the user is not a member of. -> ✅
- Channel name prefixes have been corrected. Prefixes like exercise-, lecture-, and exam- no longer appear under their respective sections. -> ✅
- Message styling options for bold, italic, underline, inline code, code block, and reference have been added. -> ✅
- A bug on the exercise page has been fixed; release date and complaint possible fields have been added. (Closes Exercise-view broken #40) -> ✅
- The exercise details page design has been revised to be more similar to the iOS design, including adjustments to the top bar. -> ✅
- A participation not possible alert has been added to the exercise details page for exercises of non-text type. (similar to iOS) -> ✅
Code Comments
Really superb coding, I reviewed all the files and have nothing to complain :D
Great work!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Testing
Just tested it, looks good in terms of functionality!
I didn't encounter any bugs except for one minor issue mentioned below. Great work!
Suggestions/Comments
I'm not sure if this is a general issue, but the exercise overview tab is not scrollable for me.
When the content of the WebView exceeds the screen, I'm not able to scroll to the bottom to see the rest of the problem statement.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this code has already been merged, but I still left some suggestions. Maybe split up future PR's into one PR per topic so they are not so large.
Added these features and enhancements before the 1st release:
Screenshots
Communication Page with Updated Sidebar & Floating Action Button with Dropdown Options
Updated Design of Create Channel Screen
Updated Design/Functionalities of Browse Channels Screen
Updated Message Input Area with new formatting options
Updated Exercise Details Page