Communication: Reintroduce foreign key constraints and offline primary keys
#70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FelberMartin
approved these changes
Oct 24, 2024
TimOrtel
reviewed
Oct 24, 2024
...formatics/www1/artemis/native_app/feature/metis/shared/db/entities/MetisPostContextEntity.kt
Outdated
Show resolved
Hide resolved
...m/informatics/www1/artemis/native_app/feature/metis/shared/db/entities/PostReactionEntity.kt
Show resolved
Hide resolved
julian-wls
approved these changes
Oct 25, 2024
TimOrtel
requested changes
Oct 25, 2024
julian-wls
approved these changes
Nov 29, 2024
FelberMartin
added
ready to merge
FelberMartin
force-pushed
the
bugfix/reimplement-foreign-keys
branch
from
b5770b9
to
8fb7338
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In the hotfix for version 1.0.1 and 1.0.2 the foreign key constraints for reactions were removed. Additionally, the primary key constraints for posts and reactions were altered to include the server_id. These changes were done to prevent the application from crashing. This however introduced the problem that while the app was running without crashes, the data integrity is not given anymore.
Description
Pull Request #58 fixed an issue with the answer threads not being shown. This issue also seemed to be the origin of the failing primary and foreign key constraints. Therefore I reverted the changes to include the previous FK and PK checks as they were.
Closes #62