-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug override globally configured pageSize variable in the middle of the code #299
Fixed bug override globally configured pageSize variable in the middle of the code #299
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Abishek,
Check out doGetAttrsList method, we seem to have lost paginated load of pivots (only first paged loaded ?) and some control are not passed on anymore.
To reproduce issue, one should have a LDAP directory with many users ( + 2000), a pageSize at 500, and an olcLimits should apply for the account that connect to source.
There when searching for over olcLimits in a dataset (for members for example), you should see less entry returns than expected (as they are limited by olcLimits), while one should expect a paginated load of theses entries so that olcLimits is not reach and no entry is missed.
847c512
to
64e3dac
Compare
@davidcoutadeur I have understood the problem better and proposed a new fix. The commits have been squashed as requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is my complete review
3308b20
to
74c3ca6
Compare
@davidcoutadeur I have applied fixes corresponding to your comments. This is ready to merge. |
226e76b
to
46d39a3
Compare
- Re-establishing default request controls
46d39a3
to
80faaeb
Compare
#176