Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DM-48106: Add new migration scripts for 2.0.1 and 3.0.0 #6

Merged
merged 3 commits into from
Jan 11, 2025

Conversation

abudlong
Copy link
Contributor

No description provided.

@abudlong abudlong requested a review from andy-slac December 22, 2024 18:33
Copy link
Collaborator

@andy-slac andy-slac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I'd recommend running black+isort+ruff on the new files. Probably easiest is to do pre-commit install and then commit some trivial changes to both files, pre-commit hook will run everything defined in .pre-commit-config.yaml.

# add empty column.
batch_op.add_column(sqlalchemy.Column("pixelScale", sqlalchemy.types.Float, nullable=True))
except sqlalchemy.exc.NoSuchTableError:
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add a comment here saying that the table is not instantiated at this time, so this exception is expected?

@abudlong abudlong force-pushed the tickets/DM-48106 branch 2 times, most recently from 350d5ae to 3733d8f Compare January 7, 2025 17:46
@abudlong abudlong merged commit ab5d7a6 into main Jan 11, 2025
14 checks passed
@abudlong abudlong deleted the tickets/DM-48106 branch January 11, 2025 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants