Skip to content

Commit

Permalink
Increase default Times Square timeouts
Browse files Browse the repository at this point in the history
Make the defaults large enough to handle some of the heavier-weight
Times Square notebooks like
https://usdf-rsp-dev.slac.stanford.edu/times-square/github/lsst/schedview_notebooks/nightly/scheduler-nightsum
that currently take 200 seconds to execute.

On data-dev I've kept the shorter timeout for testing.
  • Loading branch information
jonathansick committed Sep 12, 2024
1 parent 4ffd650 commit 56c6dc1
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 4 deletions.
4 changes: 2 additions & 2 deletions applications/times-square/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ An API service for managing and rendering parameterized Jupyter notebooks.
| cloudsql.instanceConnectionName | string | `""` | Instance connection name for a Cloud SQL PostgreSQL instance |
| cloudsql.serviceAccount | string | `""` | The Google service account that has an IAM binding to the `times-square` Kubernetes service accounts and has the `cloudsql.client` role |
| config.databaseUrl | string | None, must be set | URL for the PostgreSQL database |
| config.defaultExecutionTimeout | string | `"60"` | Default execution timeout for notebooks in seconds |
| config.defaultExecutionTimeout | string | `"300"` | Default execution timeout for notebooks in seconds |
| config.enableGitHubApp | string | `"False"` | Toggle to enable the GitHub App functionality |
| config.githubAppId | string | `""` | GitHub application ID |
| config.githubCheckRunTimeout | string | `"600"` | Timeout for GitHub check runs in seconds |
| config.githubCheckRunTimeout | string | `"900"` | Timeout for GitHub check runs in seconds |
| config.githubOrgs | string | `"lsst,lsst-sqre,lsst-dm,lsst-ts,lsst-sitcom,lsst-pst"` | GitHub organizations that can sync repos to Times Square (comma-separated). |
| config.logLevel | string | `"INFO"` | Logging level: "DEBUG", "INFO", "WARNING", "ERROR", "CRITICAL" |
| config.name | string | `"times-square"` | Name of the service. |
Expand Down
2 changes: 2 additions & 0 deletions applications/times-square/values-idfdev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ config:
databaseUrl: "postgresql://times-square@localhost/times-square"
githubAppId: "196798"
enableGitHubApp: "True"
githubCheckRunTimeout: "600" # 10 minutes
defaultExecutionTimeout: "60" # 1 minute
cloudsql:
enabled: true
instanceConnectionName: "science-platform-dev-7696:us-central1:science-platform-dev-e9e11de2"
Expand Down
4 changes: 2 additions & 2 deletions applications/times-square/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -137,10 +137,10 @@ config:
githubOrgs: "lsst,lsst-sqre,lsst-dm,lsst-ts,lsst-sitcom,lsst-pst"

# -- Timeout for GitHub check runs in seconds
githubCheckRunTimeout: "600" # 10 minutes
githubCheckRunTimeout: "900" # 15 minutes

# -- Default execution timeout for notebooks in seconds
defaultExecutionTimeout: "60" # 1 minute
defaultExecutionTimeout: "300" # 5 minutes

worker:
# -- Enable liveness checks for the arq queue
Expand Down

0 comments on commit 56c6dc1

Please sign in to comment.