DM-46137: Deploy Times Square 0.13.0 #3665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathansick
force-pushed
the
tickets/DM-46137
branch
3 times, most recently
from
4ede875 to
691de8a
Compare
This adds TS_CHECK_RUN_TIMEOUT and TS_DEFAULT_EXECUTION_TIMEOUT environment variables.
Make the defaults large enough to handle some of the heavier-weight Times Square notebooks like https://usdf-rsp-dev.slac.stanford.edu/times-square/github/lsst/schedview_notebooks/nightly/scheduler-nightsum that currently take 200 seconds to execute. On data-dev I've kept the shorter timeout for testing.
This seems better because the JupyterLab notebook execution endpoint is synchronous, so we may need to also run the noteburst jobs synchronously.
jonathansick
force-pushed
the
tickets/DM-46137
branch
from
691de8a to
3d2bd25
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version of Times Square adds timeouts for GitHub Check runs to protect against hanging Noteburst executions.
See lsst-sqre/times-square#81 and https://github.com/lsst-sqre/times-square/releases/tag/0.13.0
Also deploys noteburst 0.13.0 with support for timeouts in its jobs. https://github.com/lsst-sqre/noteburst/releases/tag/0.13.0