tickets/DM-44731: two pythons #176
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
athornton
force-pushed
the
tickets/DM-44731
branch
from
b2a4e0e to
a2e9346
Compare
athornton
force-pushed
the
tickets/DM-44731
branch
from
a2e9346 to
5d910f9
Compare
athornton
force-pushed
the
tickets/DM-44731
branch
from
231db5d to
0a39a50
Compare
athornton
force-pushed
the
tickets/DM-44731
branch
from
f145314 to
632886a
Compare
athornton
force-pushed
the
tickets/DM-44731
branch
5 times, most recently
from
7b630db to
a7336a9
Compare
athornton
force-pushed
the
tickets/DM-44731
branch
from
a7336a9 to
70d641b
Compare
athornton
force-pushed
the
tickets/DM-44731
branch
from
d7f6f80 to
6d146f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Base stack container on python3.12 and get the stack from
lsstinstall. Run user terminals and the LSST kernel in the DM Stack context, but Jupyterlab in its own venv (probably overkill, we could put all this stuff in the system python, but, you know, why not do it cleanly (well, an answer would be, we can't, apparently, hide the venv python the way we can the system one...) ?)Also: refactor a lot of the build and runtime process.
In general, Phalanx-but-not-DM-specific things are moving under
/usr/local/share/jupyterlabrather than/opt/lsst/software. Then we have to add a compatibility layer so we can spawn old and new Lab containers from the same Nublado, but we could eventually use that when existing ones age out.We almost certainly can pare down the Jupyterlab Python environment farther, and I may have overdone it with the moving to
/usr/local/share/jupyterlabbecause some of these things, like the custom logging addenda in20-logging.pyare really RSP-specific.There's actually quite a lot more to think about here in terms of organization. For example, the Hub menu interaction that goes through Gafaelfawr as well is generic to Phalanx (but not generic-to-world). But the "Rubin" firefly menu thing is obviously RSP-specific, as is displaying the image tag in the bottom frame. So we should refactor the RSP Jupyter extensions into Phalanx Jupyter extensions and RSP-specific extensions, and stuff like that.
Anyway, it's a start, and it generates containers that run.